Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/48#discussion_r15048772
  
    --- Diff: 
software/base/src/main/java/brooklyn/entity/software/http/HttpRequestSensor.java
 ---
    @@ -0,0 +1,60 @@
    +package brooklyn.entity.software.http;
    +
    +import brooklyn.config.ConfigKey;
    +import brooklyn.entity.basic.ConfigKeys;
    +import brooklyn.entity.basic.EntityLocal;
    +import brooklyn.entity.effector.AddSensor;
    +import brooklyn.event.AttributeSensor;
    +import brooklyn.event.feed.http.HttpFeed;
    +import brooklyn.event.feed.http.HttpPollConfig;
    +import brooklyn.event.feed.http.HttpValueFunctions;
    +import brooklyn.util.config.ConfigBag;
    +import brooklyn.util.time.Duration;
    +import com.google.common.base.Functions;
    +import com.google.common.base.Preconditions;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.Map;
    +
    +/**
    + * Configurable {@link brooklyn.entity.proxying.EntityInitializer} which 
adds an HTTP sensor feed to retrieve the
    + * <code>JSONObject</code> from a JSON response in order to populate the 
sensor with the indicated <code>name</code>.
    + */
    +public final class HttpRequestSensor<T> extends AddSensor<T, 
AttributeSensor<T>> {
    --- End diff --
    
    This looks really useful.
    
    Over time, given its name of `HttpRequestSensor`, I can imagine us adding 
support for other things like xquery for XML content, or for comparing the http 
status code, etc.
    
    Can you mark the class as `@Beta` to give us more scope for such extensions 
in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to