Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/77#discussion_r15101375
--- Diff:
core/src/main/java/brooklyn/management/internal/LocalLocationManager.java ---
@@ -44,6 +47,9 @@
public class LocalLocationManager implements LocationManager {
+ public static final ConfigKey<Boolean> CREATE_UNMANAGED =
ConfigKeys.newBooleanConfigKey("brooklyn.internal.location.createUnmanaged",
--- End diff --
Great to to stop this happening repeatedly! Longer term I'd like to see how
we can get the information without instantiating a location at all. I think
we're on the same page there, with your comment:
// TODO should clean up how locations are stored, figuring out whether
they are shared or not;
// or maybe better, the API calls to this might just want to get the
LocationSpec objects back
I wondered about us marking `CREATE_UNMANAGED` as `@Beta`, but it's in a
package named "internal" anyway. If/when we fix `resolveForPeeking` to do it a
different way, I'd like to delete `CREATE_UNMANAGED` (unless there are any
other compelling use-cases).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
