GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/98
BrooklynRestApiLauncher rework
* Reworks `BrooklynRestApiLauncher` to make it simpler to launch servers
with different configurations of contexts, filters, security providers, etc.
* Fixes interaction between `BrooklynPropertiesSecurityFilter` and
`FormMapProvider`. See `BrooklynPropertiesSecurityFilterTest` for test.
Misc comments:
* Null check added to TestEntityImpl to make invocation from effector in
`BrooklynPropertiesSecurityFilterTest` fail if FormMapProvider wasn't used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn bral-rework
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 1bcb92962ef7f15acdbf96e0273db1fde485100e
Author: Sam Corbett <[email protected]>
Date: 2014-07-25T17:39:46Z
Reworks BrooklynRestApiLauncher
Makes it much simpler to launch servers in any context, with whatever
security provider you want, custom filters and with or without the jsgui.
commit 43981a65b0ff51bb721d9138eeb6b2e6bb014694
Author: Sam Corbett <[email protected]>
Date: 2014-07-25T17:41:25Z
Alters logging in BrooklynPropertiesSecurityFilter to not read request body
.. at least before the chain has been processed. Adds an integration test
to verify that the interaction between the filter and FormMapProvider
works as expected.
commit dfcb0992e876b8d1ae1cd7750574d4f62dcc9ef3
Author: Sam Corbett <[email protected]>
Date: 2014-07-25T17:41:40Z
Adds failing test in BrooklynNodeRestTest to WIP group
commit b95a10fd28101392f93453d96915314819fc01ad
Author: Sam Corbett <[email protected]>
Date: 2014-07-25T17:42:28Z
Tidies getUser functionality in jsgui and quietens jsgui build
commit 29543c0ef0282a52cd4a0b8001d0b884d0c40928
Author: Sam Corbett <[email protected]>
Date: 2014-07-25T17:43:12Z
Miscellaneous tidies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
