Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/81#discussion_r15459436
--- Diff:
software/nosql/src/main/java/brooklyn/entity/nosql/cassandra/CassandraNodeImpl.java
---
@@ -84,6 +90,21 @@
public CassandraNodeImpl() {
}
+ @Override
+ public void init() {
+ super.init();
+
+ getMutableEntityType().addEffector(EXECUTE_SCRIPT, new
EffectorBody<String>() {
--- End diff --
No good reason in my opinion - just makes the code harder to understand
when there's no need for it to be dynamic. This code was already there, and is
a bit fiddly to change because it's reusing
`CassandraDatacenter.EXECUTE_SCRIPT` which reuses
`DatastoreMixins.EXECUTE_SCRIPT`, both of which are built as "abstract"
effectors.
Will leave this as-is for this PR.
I believe @ahgittin wrote this - Alex is keenest on dynamic effectors.
My view is they have their place when there is a need for it to be dynamic,
but is just unnecessary indirection when a static `@Effector` annotation would
do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
