Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/91#discussion_r15523548
--- Diff: core/src/main/java/brooklyn/util/task/ssh/SshTasks.java ---
@@ -130,9 +131,24 @@ public static SshFetchTaskFactory
newSshFetchTaskFactory(SshMachineLocation mach
return result;
}
+ @Beta
+ public static enum OnFailingTask { FAIL,
WARN_OR_FAIL_INESSENTIAL_IF_DYNAMIC, WARN_IN_LOG_ONLY, IGNORE }
--- End diff --
Would prefer a blank line after this enum.
Also `WARN_OR_FAIL_INESSENTIAL_IF_DYNAMIC` is a hard-to-understand name. It
wasn't obvious where the grouping is: i.e. WARN IF NOT INESSENTIAL OR NOT
DYNAMIC; FAIL IF INESSENTIAL AND IF DYNAMIC. At least needs javadoc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
