Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/101#discussion_r15705875
--- Diff:
usage/test-support/src/main/java/brooklyn/test/EntityTestUtils.java ---
@@ -144,4 +146,12 @@ public static void
assertAttributeChangesEventually(final Entity entity, final A
((EntityLocal)entity).unsubscribe(entity, handle);
}
}
+
+ /** alternate version of {@link
#assertAttributeChangesEventually(Entity, AttributeSensor)} not using
subscriptions and
+ * with simpler code, for comparison */
+ @Beta
+ public static <T> void assertAttributeChangesEventually2(final Entity
entity, final AttributeSensor<T> attribute) {
--- End diff --
I'd include a `TODO` comment that one of them should be deleted. Agree
yours is simpler. I'd be fine with us doing that, as this code does not need to
be very performant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
