Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/109#discussion_r15925908
--- Diff: core/src/main/java/brooklyn/util/osgi/Osgis.java ---
@@ -214,16 +213,8 @@ private static void
installExtensionBundle(BundleContext bundleContext, URL mani
if("felix.extensions".equals(manifestUrl.getHost())) return;
try {
- Manifest manifest;
- try {
- manifest = readManifest(manifestUrl);
- if (!isValidBundle(manifest)) return;
- } catch (Exception e) {
- Exceptions.propagateIfFatal(e);
- // assume invalid manifest (however it normally follows
the above path)
- LOG.warn("Not able to install extension bundle from " +
manifestUrl + "; probably it is not a bundle, ignoring: "+e, e);
- return;
- }
+ Manifest manifest = readManifest(manifestUrl);
--- End diff --
Does this revert the change you made in commit bf627f7? Not sure I follow
why. Did you conclude it wasn't needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
