Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/115#discussion_r16181802
--- Diff:
usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherTest.java ---
@@ -219,6 +221,7 @@ public void
testReloadBrooklynPropertiesRestoresProgrammaticProperties() throws
@Test
public void testReloadBrooklynPropertiesFromFile() throws Exception {
File globalPropertiesFile =
File.createTempFile("local-brooklyn-properties-test", ".properties");
+ FileUtil.setFilePermissionsTo600(globalPropertiesFile);
--- End diff --
No `FileUtil` diffs in this commit? Surely that method didn't already
exist?!
Suggest it's cleaner to have `setFilePermissions(File, int)`, and to use
hex instead of decimal when invoking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
