GitHub user sjcorbett opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/126

    jsgui: Attach policies to existing entities

    * Adds generic modal view to brooklyn.view.js to simplify handling of modal 
lifecycles
    * Adds view for input of config key names/values
    * Exposes `PolicyApi.addPolicy`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/incubator-brooklyn 
jsgui-add-policy-existing-entity

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #126
    
----
commit 33bb7a05da3734d905665a494f9ef26c2672051b
Author: Sam Corbett <[email protected]>
Date:   2014-08-15T11:07:12Z

    jsgui: Clear datatable so no duplicates when clicking between policies

commit de3044fcfc5d29563ef4a8d5d3e44e324fa3d937
Author: Sam Corbett <[email protected]>
Date:   2014-08-19T09:30:54Z

    Moves configuration of Backbone.View.prototype from router to view.js

commit cfc3a3c6293017ab729b73c0f64f36c69e0a1428
Author: Sam Corbett <[email protected]>
Date:   2014-08-19T09:32:40Z

    jsgui: Adds generic modal and config key input views

commit 5c8f4401c02b6766b393193615027782932f8273
Author: Sam Corbett <[email protected]>
Date:   2014-08-20T09:11:36Z

    jsgui: Attach new policies to entities
    
    Basic implementation. Need to know the type of the policy.

commit 17b7e669faf83b63c835a4abd66b8bf492e59f75
Author: Sam Corbett <[email protected]>
Date:   2014-08-20T11:08:00Z

    Rework policy config editing
    
    * Uses generic modal view rather than managing a modal itself
    * Improved error display
    * Shows default values in policy config table
    * Adds Brooklyn.view.showModalWith(View) shortcut

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to