Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/118#discussion_r16549081
--- Diff:
software/nosql/src/test/java/brooklyn/entity/nosql/couchdb/CouchDBNodeLiveTest.java
---
@@ -47,18 +47,18 @@
@DataProvider(name = "virtualMachineData")
public Object[][] provideVirtualMachineData() {
- return new Object[][] { // ImageName, Provider, Region
- new Object[] { "ubuntu", "aws-ec2", "eu-west-1" },
- new Object[] { "Ubuntu 12.0", "rackspace-cloudservers-uk", ""
},
- new Object[] { "CentOS 6.2", "rackspace-cloudservers-uk", "" },
+ return new Object[][] { // ImageId, Provider, Region, Description
(for logging)
+ new Object[] { "eu-west-1/ami-0307d674", "aws-ec2",
"eu-west-1", "Ubuntu Server 14.04 LTS (HVM), SSD Volume Type" },
--- End diff --
A shame we can't use `imageNameRegex`, but I believe AWS-EC2 and Rackspace
are different for whether they use name or description so can't use the same
config for both. We could pass a map of additional provisioning args (e.g.
`ImmutableMap.of("imageNameRegex", ".*Ubuntu.*14.04.*")` or whatever it is).
However, let's come back to that later.
If I'd been fixing this, I'd have included a `TODO` comment saying about it
failing (with the date), and about it previously not being tested properly. But
I'm fine merging this as is now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
