[ 
https://issues.apache.org/jira/browse/BROOKLYN-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149073#comment-14149073
 ] 

ASF GitHub Bot commented on BROOKLYN-70:
----------------------------------------

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/190#discussion_r18085473
  
    --- Diff: software/base/src/main/java/brooklyn/entity/chef/ChefTasks.java 
---
    @@ -81,7 +87,13 @@ public void run() {
     //                    // remove reference to 'force' below
     //                }
                     
    -                tb.add(ArchiveTasks.deploy(null, cookbookArchiveUrl, 
EffectorTasks.findSshMachine(), 
privateTmpDirContainingUnpackedCookbook).newTask());
    +                String destName = null;
    +                if 
(ArchiveType.of(cookbookArchiveUrl)==ArchiveType.UNKNOWN) {
    +                    destName = cookbookName + ".tgz";
    --- End diff --
    
    Theoretically cookbookName could contain non-file-system-safe characters 
(though using such key names is asking for trouble).


> new chef community site uses different download links not compatible with 
> brooklyn-chef support
> -----------------------------------------------------------------------------------------------
>
>                 Key: BROOKLYN-70
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-70
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: Alex Heneveld
>
> it used to be that the preferred URL was the github release, e.g.
>     (1) https://github.com/poise/poise/archive/v1.0.10.tar.gz
> now they seem to offer a convenience link at
>     (2) https://community.opscode.com/cookbooks/poise/versions/1.0.10/download
> which redirects to a CDN:
>     (3) 
> https://s3.amazonaws.com/community-files.opscode.com/cookbook_versions/tarballs/6179/original/poise.tgz?1394831504
> WORKAROUND
> until we support this new chef community mechanism (which will require some 
> work, because we have to be smarter about how we unpack the archive), instead 
> of using (2) above users should follow the "View Source" link to github then 
> the "<#> Releases" link and get the github TGZ for the recipe(s) desired.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to