Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/165#discussion_r18203176
  
    --- Diff: 
software/base/src/main/java/brooklyn/entity/basic/SoftwareProcess.java ---
    @@ -102,17 +105,29 @@
         @Deprecated
         ConfigKey<String> SUGGESTED_RUN_DIR = 
BrooklynConfigKeys.SUGGESTED_RUN_DIR;
     
    -    /** Files to be copied to the server, map of "subpath/file.name": 
"classpath://foo/file.txt" (or other url) */
    +    /** Files to be copied to the server before install. Map of 
"subpath/file.name" to "classpath://foo/file.txt" (or other url) */
    +    @SuppressWarnings("serial")
    +    @SetFromFlag("installFiles")
    +    ConfigKey<Map<String, String>> INSTALL_FILES = 
ConfigKeys.newConfigKey(new TypeToken<Map<String, String>>() { },
    +            "files.install", "Map of files to be copied, before install 
keyed by destination name relative to runDir");
    --- End diff --
    
    Assume "relative to runDir" should be "relative to installDir"? Worth 
making this explicit in the javadoc too, to clarify the meaning of "subpath".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to