Alex, I've modified the Jenkins job configure to disable "Incremental build - only build changed modules" - the help text for this option describes exactly the behaviour we are seeing. We'll see if this makes a difference.
Richard. On 2 October 2014 09:07, Alex Heneveld <[email protected]> wrote: > > Hi Andrew, > > I've opened an issue for the mail approval [1]. > > We've noticed a more significant problem however-- the PR builds need to do > a full build I think, not an incremental build, because there will be > out-of-band changes. (We're getting spurious failures.) See [2]. > >> Oh, and thanks for being a guinea pig. =) > > We're delighted to be the subject in your animal testing! Thanks. > > Best > Alex > > [1] https://issues.apache.org/jira/browse/INFRA-8422 > [2] https://issues.apache.org/jira/browse/INFRA-8423 > > > > > On 01/10/2014 23:31, Andrew Bayer wrote: >> >> Oh, and thanks for being a guinea pig. =) >> >> A. >> >> On Wed, Oct 1, 2014 at 3:16 PM, Andrew Bayer <[email protected]> >> wrote: >>> >>> Fun - open an INFRA JIRA - we should hopefully be able to fiddle with >>> that. >>> >>> A. >>> >>> On Wed, Oct 1, 2014 at 3:12 PM, Alex Heneveld >>> <[email protected]> wrote: >>>> >>>> We've gotten a few PR build emails - seems to be working. Thanks Andrew. >>>> >>>> However unlike mere mortals' mails Jenkins seems to require moderator >>>> approval on every mail. So apologies in advance if your build failure or >>>> success gets held up in the post! >>>> >>>> Best >>>> Alex >>>> On 1 Oct 2014 21:18, "Andrew Bayer" <[email protected]> wrote: >>>> >>>>> Took some tweaks - we had the wrong form encoding and were missing a >>>>> trailing slash on the hook url (oy!), but - >>>>> https://builds.apache.org/job/incubator-brooklyn-pull-requests/ - >>>>> building PRs! >>>>> >>>>> A. >>>>> >>>>> On Wed, Oct 1, 2014 at 2:34 AM, Richard Downer <[email protected]> >>>>> wrote: >>>>>> >>>>>> Hi Andrew, >>>>>> >>>>>> No success so far I'm afraid... these PRs: >>>>>> https://github.com/apache/incubator-brooklyn/pull/198 >>>>>> https://github.com/apache/incubator-brooklyn/pull/199 >>>>>> were opened yesterday but there's no sign of anything trying to build >>>>>> it. >>>>>> >>>>>> These PRs: >>>>>> https://github.com/apache/incubator-brooklyn/pull/165 >>>>>> https://github.com/apache/incubator-brooklyn/pull/194 >>>>>> were opened earlier, but have had commits added yesterday, and again >>>>>> no sign of life. >>>>>> >>>>>> The Jenkins job you linked to: >>>>>> https://builds.apache.org/job/incubator-brooklyn-pull-requests/ >>>>>> is showing that no builds have been attempted yet. >>>>>> >>>>>> Can you take a look and see what's happening? >>>>>> >>>>>> Thanks! >>>>>> Richard. >>>>>> >>>>>> >>>>>> On 29 September 2014 17:10, Andrew Bayer <[email protected]> >>>>>> wrote: >>>>>>> >>>>>>> Jake set up the hook, and I set up the build - >>>>>>> https://builds.apache.org/job/incubator-brooklyn-pull-requests/ - >>>>>>> lemme know how it works for and/or if you need any help! >>>>>>> >>>>>>> A. >>>>>>> >>>>>>> On Fri, Sep 26, 2014 at 2:27 PM, Richard Downer <[email protected]> >>>>> >>>>> wrote: >>>>>>>> >>>>>>>> (Crossposting to dev@brooklyn) >>>>>>>> >>>>>>>> Fantastic Andrew, sounds like just what we want :-) >>>>>>>> >>>>>>>> Our repo is incubator-brooklyn, and the GitHub side[1] is done using >>>>>>>> Apache infra's GitHub mirroring - so the admin rights belong to the >>>>>>>> Apache infra user(s) rather than anybody in the Brooklyn PPMC. >>>>>>>> >>>>>>>> We already have the "master" branch built at [2], so I guess you >>>>>>>> will >>>>>>>> need to make a second job (cloned from it) for building PRs - please >>>>>>>> go ahead! >>>>>>>> >>>>>>>> Richard. >>>>>>>> >>>>>>>> [1]https://github.com/apache/incubator-brooklyn/ >>>>>>>> [2]https://builds.apache.org/view/A-D/view/Brooklyn/ >>>>>>>> >>>>>>>> >>>>>>>> On 26 September 2014 14:54, Andrew Bayer <[email protected]> >>>>> >>>>> wrote: >>>>>>>>> >>>>>>>>> Hey, I've been looking for a guinea pig for exactly this! =) >>>>>>>>> >>>>>>>>> We've got the Jenkins Enterprise plugins on builds.apache.org, >>>>>>>>> which >>>>>>>>> includes the CloudBees GitHub pull request builder plugin. That's >>>>> >>>>> basically >>>>>>>>> >>>>>>>>> the same thing as on BuildHive, and is in my opinion far preferable >>>>> >>>>> to the >>>>>>>>> >>>>>>>>> open source GitHub PR builder plugin, which requires push acces to >>>>> >>>>> the repo >>>>>>>>> >>>>>>>>> and is extremely chatty. The one we've got installed just listens >>>>>>>>> for >>>>> >>>>> pull >>>>>>>>> >>>>>>>>> requests, builds them, and comments on the pull request with the >>>>> >>>>> result. >>>>>>>>> >>>>>>>>> I'd love to help Brooklyn get a job in place on builds.apache.org >>>>> >>>>> using it >>>>>>>>> >>>>>>>>> - I'll need to get someone with admin rights to the Apache GH repos >>>>> >>>>> to add >>>>>>>>> >>>>>>>>> the relevant hook to the Brooklyn repo, but once that's done, we >>>>>>>>> can >>>>> >>>>> get >>>>>>>>> >>>>>>>>> this going with you right away. >>>>>>>>> >>>>>>>>> A. >>>>>>>>> >>>>>>>>> On Friday, September 26, 2014, Richard Downer <[email protected]> >>>>> >>>>> wrote: >>>>>>>>>> >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> Brooklyn (incubating) have been looking at the Buildhive[1] >>>>>>>>>> service >>>>>>>>>> and we are wondering if it is possible to integrate this service, >>>>>>>>>> or >>>>> >>>>> a >>>>>>>>>> >>>>>>>>>> similar one, into our Apache infrastructure. I've provided a short >>>>>>>>>> description below for those who are not familiar with it. We used >>>>>>>>>> to >>>>>>>>>> run this service prior to entering the incubator and we are >>>>>>>>>> missing >>>>>>>>>> it! >>>>>>>>>> >>>>>>>>>> We'd like to know if the Apache infrastructure supports anything >>>>>>>>>> like >>>>>>>>>> this - either Buildhive itself or a similar service. >>>>>>>>>> >>>>>>>>>> A search through the Apache archives reveals that jclouds is using >>>>>>>>>> Buildhive extensively, although I am aware that jclouds' >>>>>>>>>> infrastructure setup is somewhat atypical for an >>>>>>>>>> Apache/GitHub-style >>>>>>>>>> project. I could not find any other project referring to this tool >>>>>>>>>> in >>>>>>>>>> either the mail-archives or JIRA, so I am assuming that jclouds is >>>>> >>>>> the >>>>>>>>>> >>>>>>>>>> only user. >>>>>>>>>> >>>>>>>>>> As an alternative to the external Buildhive service, there is also >>>>>>>>>> a >>>>>>>>>> Jenkins plugin[2]. I haven't tried this myself so I don't know how >>>>>>>>>> effective it is, but it may be worth a trial if it's preferred to >>>>> >>>>> keep >>>>>>>>>> >>>>>>>>>> these kinds of services internal. A search of the archives did not >>>>>>>>>> confirm if any Apache project is using this, either. >>>>>>>>>> >>>>>>>>>> What is Apache's experiences with this kind of service? >>>>>>>>>> >>>>>>>>>> ============ >>>>>>>>>> >>>>>>>>>> Buildhive is a service that uses GitHub hooks to detect when a >>>>>>>>>> pull >>>>>>>>>> request is issued. It causes the code in the PR to be sent to a >>>>>>>>>> Jenkins instance for a build; Buildhive will then post a comment >>>>>>>>>> on >>>>>>>>>> the PR to say if the build succeeded or not. >>>>>>>>>> >>>>>>>>>> This provides an early warning, both for the contributor and the >>>>>>>>>> committers, if a particular contribution is likely to break the >>>>> >>>>> build. >>>>>>>>>> >>>>>>>>>> As these kinds of services generally want to use GitHub hooks, >>>>>>>>>> which >>>>>>>>>> requires the repository organisation owner to install, it would >>>>>>>>>> need >>>>>>>>>> the infrastructure team's help to set it up. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> [1]https://buildhive.cloudbees.com/ >>>>>>>>>> [2] >>>>>>>>>> >>>>> >>>>> https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Richard. >>>>>>>>>> >
