Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/265#discussion_r19205184
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -797,7 +798,7 @@ public void apply(TemplateBuilder tb, ConfigBag props,
Object v) {
}})
.put(MIN_DISK, new CustomizeTemplateBuilder() {
public void apply(TemplateBuilder tb, ConfigBag props,
Object v) {
- tb.minDisk(TypeCoercions.coerce(v, Double.class));
+ tb.minDisk( (int)(ByteSizeStrings.parse(""+v,
"g")/1024/1024/1024) );
--- End diff --
Why divide this by `1024`? Disk MB are normally `10^6` - see
http://en.wikipedia.org/wiki/Megabyte#Definitions
Same applies for GB (10^9 for disks, and 2^30 for RAM).
Do we need different `ByteSizeStrings.parse` methods / configuration?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
