Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/263#discussion_r19491346
--- Diff:
software/network/src/main/java/brooklyn/entity/network/bind/BindDnsServerImpl.java
---
@@ -86,8 +89,11 @@ public String getDomainName() {
return getConfig(DOMAIN_NAME);
}
+ /**
+ * @return A serial number guaranteed to be valid for use in a
modified domain.zone or reverse.zone file.
+ */
public long getSerial() {
- return serial.incrementAndGet();
+ return getAttribute(SERIAL).incrementAndGet();
--- End diff --
I'd prefer `setAttribute(getAttribute(SERIAL) + 1)`, with the type being
`Long` rather than `AtomicLong`.
At some point we may hook in to setAttribute for more efficient persistence
or a datagrid...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
