Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/304#discussion_r19935879
--- Diff:
locations/jclouds/src/test/java/brooklyn/entity/rebind/persister/jclouds/BlobStoreExpiryTest.java
---
@@ -151,7 +150,7 @@ protected void doTestRenewAuth(boolean applyFix) throws
IOException {
try {
assertContainerFound();
Assert.fail("should fail as long as "+RetryOnRenew.class+"
is not working");
- } catch (Exception e) {
+ } catch (AssertionError e) {
--- End diff --
This doesn't make sense to me. We do `Assert.fail()` on line 152, which is
guaranteed to throw an `AssertionError`, then we catch it and log that we
expected it.
I thought the intent of the catch-block was that the `assertContainerFound`
should throw an exception (not a failing assertion) because the token had
expired.
When I run it, I see the log message `failed, as expected:
java.lang.AssertionError: should fail as long as class
org.jclouds.openstack.handlers.RetryOnRenew is not working`, so the suggestion
it "failed, as expected" isn't correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
