Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/312#discussion_r20136821
--- Diff: core/src/main/java/brooklyn/management/ha/OsgiManager.java ---
@@ -137,24 +162,26 @@ public void registerBundle(String bundleUrl) {
}
return Maybe.of(clazz);
} else {
- bundleProblems.put(bundleUrlOrNameVersionString, new
IllegalStateException("Unable to find bundle "+bundleUrlOrNameVersionString));
+ bundleProblems.put(catalogBundle, new
IllegalStateException("Bundle is not installed"));
}
} catch (Exception e) {
Exceptions.propagateIfFatal(e);
- if (noVersionInstalled) {
- if (bundleUrlOrNameVersionString.contains("/")) {
- // suppress misleading nested trace if the input
string looked like a URL
- bundleProblems.put(bundleUrlOrNameVersionString,
new IllegalStateException("Bundle does not appear to be installed"));
- } else {
- bundleProblems.put(bundleUrlOrNameVersionString,
new IllegalStateException("Bundle does not appear to be installed", e));
- }
- } else {
- bundleProblems.put(bundleUrlOrNameVersionString, e);
- }
+//TODO Can't figure out the logic of the following branching.
--- End diff --
Yes, forgot to update this. It is no longer needed because
getRegisteredBundle doesn't throw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
