Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/320#discussion_r20188607
--- Diff:
core/src/main/java/brooklyn/entity/rebind/BasicLocationRebindSupport.java ---
@@ -68,9 +69,9 @@ protected void addConfig(RebindContext rebindContext,
LocationMemento memento) {
// FIXME Treat config like we do for entities; this code will
disappear when locations become entities.
// Note that the flags have been set in the constructor
- // FIXME Relies on location.getLocalConfigBag being mutable (to
modify the location's own config)
+ // FIXME Relies on location.config().getLocalBag() being mutable
(to modify the location's own config)
--- End diff --
Note that I haven't dealt with this FIXME. It still works because
`location.config().getLocalBag()` is returning a mutable object (despite
`BrooklynObjectInternal.ConfigurationSupportInternal.getLocalBag()` javadoc
saying it is read-only). I suggest we tackle that in a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
