Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/309#discussion_r20234519
  
    --- Diff: core/src/test/java/brooklyn/entity/rebind/RebindTestUtils.java ---
    @@ -221,71 +224,196 @@ public LocalManagementContext buildStarted() {
     
         }
     
    +    /**
    +     * Convenience for common call; delegates to {@link 
#rebind(RebindOptions)}
    +     */
         public static Application rebind(File mementoDir, ClassLoader 
classLoader) throws Exception {
    -        return rebind(mementoDir, classLoader, null);
    +        return rebind(RebindOptions.create()
    +                .mementoDir(mementoDir)
    +                .classLoader(classLoader));
         }
    --- End diff --
    
    I'd be inclined to deprecate this version too, but no strong feelings. How 
common is the "common call"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to