Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/314#discussion_r20302497
--- Diff: core/src/main/java/brooklyn/config/BrooklynServerConfig.java ---
@@ -55,31 +54,50 @@
public static final ConfigKey<String> BROOKLYN_DATA_DIR =
newStringConfigKey(
"brooklyn.datadir", "Directory for writing all brooklyn data");
- public static final String DEFAULT_PERSISTENCE_CONTAINER_NAME =
"brooklyn-persisted-state";
- /** on file system, the 'data' subdir is used so that there is an
obvious place to put backup dirs */
- public static final String DEFAULT_PERSISTENCE_DIR_FOR_FILESYSTEM =
Os.mergePaths(DEFAULT_PERSISTENCE_CONTAINER_NAME, "data");
-
/**
* Provided for setting; consumers should query the management context
persistence subsystem
- * for the actual target, or use {@link
#resolvePersistencePath(String, StringConfigMap, String)}
+ * for the actual target, or use {@link
BrooklynServerPaths#newMainPersistencePathResolver(ManagementContext)}
* if trying to resolve the value
*/
public static final ConfigKey<String> PERSISTENCE_DIR =
newStringConfigKey(
"brooklyn.persistence.dir",
- "Directory or container name for writing brooklyn persisted
state");
+ "Directory or container name for writing persisted state");
public static final ConfigKey<String> PERSISTENCE_LOCATION_SPEC =
newStringConfigKey(
"brooklyn.persistence.location.spec",
- "Optional location spec string for an object store (e.g.
jclouds:swift:URL) where persisted state should be kept;"
+ "Optional location spec string for an object store (e.g.
jclouds:swift:URL) where persisted state should be kept; "
+ "if blank or not supplied, the file system is used");
+ public static final ConfigKey<String> PERSISTENCE_BACKUPS_DIR =
newStringConfigKey(
+ "brooklyn.persistence.backups.dir",
+ "Directory or container name for writing backups of persisted
state; "
+ + "defaults to 'backups' inside the default persistence
directory");
+
+ public static final ConfigKey<String>
PERSISTENCE_BACKUPS_LOCATION_SPEC = newStringConfigKey(
+ "brooklyn.persistence.backups.location.spec",
+ "Location spec string for an object store (e.g. jclouds:swift:URL)
where backups of persisted state should be kept; "
+ + "defaults to the same location spec as regular persisted state,
failing back to local file system");
--- End diff --
Always defaults to local file system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
