Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/331#issuecomment-63152574
last two commits look pretty good - merging.
not convinced we have the catalog sorting strategy right, but we can refine
it.
* this approach, if i understand correctly, splits on and otherwise ignores
non-digits. but that could be surprising. if i have `beta1` and `rc2` i'd be
pleased that `rc2` wins, even if it's for alphabetic reasons; but if i then
release `beta3` i'd be surprised to see it come first. we should include
alphabetic items in the items we sort on (and use the natural order comparator
so rc10 > rc1 !)
* it would also be sensible to have special logic that, given two versions
identical up to a qualifier we prefer the non-qualified item -- ie prefer
`0.3.0` over `0.3.0_rc1`. (but we should be careful *not* to prefer `1` over
`1.3` !)
* also your commit message suggests that `NaturalOrderComparator` sorts
`0.0.0_SNAPSHOT` higher than `0.0.1-SNAPSHOT-20141111114709760` -- i'm
surprised by that, is there a good reason? however i agree with the spirit
that `_` and `-` should not be significant for determining sort order here and
i can see other areas where it might cause problems (minor ones, but still...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
