Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/347#discussion_r20567243
  
    --- Diff: software/base/src/main/java/brooklyn/entity/java/UsesJmx.java ---
    @@ -43,7 +43,12 @@
         /** Chosen by Java itself by default, setting this will only have any 
effect if using an agent. */
         @SetFromFlag("jmxPort")
         PortAttributeSensorAndConfigKey JMX_PORT = new 
PortAttributeSensorAndConfigKey(
    -            "jmx.direct.port", "JMX direct/private port (e.g. JMX RMI 
server port, or JMXMP port, but not RMI registry port)", 
PortRanges.fromString("31001+")) {
    +        "jmx.direct.port", "JMX direct/private port (e.g. JMX RMI server 
port, or JMXMP port, but not RMI registry port)", 
PortRanges.fromString("31001+"));
    +    
    +    /** @deprecated since 0.7.0, kept for rebinding, use {@link #JMX_PORT} 
*/ @Deprecated
    +    PortAttributeSensorAndConfigKey JMX_PORT_LEGACY = new 
PortAttributeSensorAndConfigKey(
    --- End diff --
    
    Worth a note that we are keeping it just for the anonymous class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to