Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/352#discussion_r20643844
--- Diff: core/src/main/java/brooklyn/event/feed/http/HttpPollConfig.java
---
@@ -159,9 +160,12 @@ public URI buildUri(URI baseUri, Map<String,String>
baseUriVars) {
return MutableMap.<K,V>builder().putAll(map1).putAll(map2).build();
}
+ @Override protected String toStringBaseName() { return "http"; }
+ @Override protected String toStringPollSource() { return suburl; }
@Override
- public String toString() {
- return "http["+suburl+"]";
+ protected MutableList<Object> equalsFields() {
+ return
super.equalsFields().appendIfNotNull(method).appendIfNotNull(vars).appendIfNotNull(headers)
--- End diff --
Is IfNotNull the right approach? Better to have positional fields even if
they are null. Or is it a future-proof approach for new versions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
