Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/358#discussion_r21097945
  
    --- Diff: core/src/main/java/brooklyn/util/internal/ssh/ShellTool.java ---
    @@ -55,9 +56,13 @@
         public static final ConfigKey<String> PROP_DIRECT_HEADER = 
newConfigKey("directHeader", "commands to run at the target before any 
caller-supplied commands for direct execution", "exec bash -e");
     
         ConfigKey<Boolean> PROP_NO_DELETE_SCRIPT = 
newConfigKey("noDeleteAfterExec", "Retains the generated script file after 
executing the commands instead of deleting it", false);
    -    
    +
         ConfigKey<String> PROP_SUMMARY = 
ConfigKeys.newStringConfigKey("summary", "Provides a human-readable summary, 
used in file generation etc");
         
    +    ConfigKey<Boolean> PROP_EXEC_ASYNC = newConfigKey("execAsync", 
"Executes the script asynchronously, and then polls for the result (and for 
stdout/stderr)", false);
    +
    +    ConfigKey<Duration> PROP_EXEC_ASYNC_TIMEOUT = 
newConfigKey("execAsyncTimeout", "Timeout when executing a script 
asynchronously", Duration.PRACTICALLY_FOREVER);
    --- End diff --
    
    Perhaps have a shorter timeout for the default, maybe 15 minutes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to