Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/375#discussion_r21528108
--- Diff:
software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
@@ -521,9 +532,14 @@ protected void restartChildren(ConfigBag parameters) {
* invokes {@link #preStopCustom()}, {@link
#stopProcessesAtMachine()}, then finally
* {@link #stopAnyProvisionedMachines()} and sets state {@link
Lifecycle#STOPPED}
*/
- public void stop() {
+ public void stop(ConfigBag parameters) {
log.info("Stopping {} in {}", entity(), entity().getLocations());
+ StopSoftwareParameters.StopMachineMode isStopMachine =
parameters.get(StopSoftwareParameters.STOP_MACHINE_TYPED);
+
+ if (isStopMachine==null)
+ isStopMachine=StopSoftwareParameters.StopMachineMode.TRUE;
--- End diff --
General note: I'm a fan of white space around operators (as advocated in
the various coding standards such as from Oracle and Google). But consistency
with the other code trumps that. Therefore I'd for for ` = ` for he assignment,
but ok to not have spaces around the `==` on previous line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
