Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/355#discussion_r22662374
  
    --- Diff: 
software/network/src/main/java/brooklyn/entity/network/bind/BindDnsServerSshDriver.java
 ---
    @@ -126,4 +143,41 @@ private void copyAsRoot(String template, String 
destination) {
             getMachine().execScript("copying file", 
ImmutableList.of(BashCommands.sudo(String.format("mv %s %s", temp, 
destination))));
         }
     
    +    /** @return The location on the server of the domain zone file */
    +    public String getDomainZoneFile() {
    +        return Os.mergePaths(getOsSupport().getConfigDirectory(), 
"domain.zone");
    +    }
    +
    +    /** @return The location on the server of the reverse zone file */
    +    public String getReverseZoneFile() {
    +        return Os.mergePaths(getOsSupport().getConfigDirectory(), 
"reverse.zone");
    +    }
    +
    +    public String getDataDirectory() {
    +        return Os.mergePaths(getOsSupport().getWorkingDirectory(), "data");
    +    }
    +
    +    public String getDynamicDirectory() {
    +        return Os.mergePaths(getOsSupport().getWorkingDirectory(), 
"dynamic");
    +    }
    +
    +    public String getRfc1912ZonesFile() {
    +        return Os.mergePaths(getOsSupport().getConfigDirectory(), 
"rfc1912.zone");
    +    }
    +
    +    public BindOsSupport getOsSupport() {
    +        BindOsSupport result = osSupport;
    +        if (result == null) {
    +            synchronized(this) {
    --- End diff --
    
    Create a specific `Object` mutex for all synchronization, never `this`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to