GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/489
Maven javac purity
builds on #470, fixing issues i saw which appear to be java7 related
the stack overflow @neykov reports at
https://github.com/apache/incubator-brooklyn/pull/470#issuecomment-71441391 is
truly strange, and worrying. i do not experience it -- this builds fine for me.
let's see what jenkins has to say!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn maven-javac-purity
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/489.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #489
----
commit c34812c66a46ebac2fe95a808b257fdf92ec70e3
Author: Svetoslav Neykov <[email protected]>
Date: 2015-01-24T21:22:39Z
Use javac to compile non-test code
Still use groovy-eclipse for test-support & groovy-utils due to existing
.groovy code.
commit 4c1d54b9eac17cdad475c2b10dd0c668e854d180
Author: Svetoslav Neykov <[email protected]>
Date: 2015-01-25T09:03:20Z
Use groovy compiler where really necessary.
Override the compiler per-project, only where there are groovy files to
compile. Convert one of the groovy files to java.
commit bfb6452e36f4131b8dfa38ca7cbfc78d6af67bcb
Author: Svetoslav Neykov <[email protected]>
Date: 2015-01-26T12:31:39Z
Add the eclipse java compiler as an option for the whole project
Using a user provided compiler could lead to unexpected results (i.e. bugs,
changing behaviour) so as an alternative add the option to compile the project
with the eclipse compiler. It's much like the approach so far of using the
eclipse-groovy-compiler, but not set as the default.
To compile successfully I had to rename a package, matching (case
insensitive) to an existing class. Looks like OS X's case insensitive file
system is at the root (probably an issue under windows as well).
https://jira.codehaus.org/browse/PLX-458.
To use add -Peclipse-compiler to the maven command.
commit 97d21ce35847555318495d8023ddfe42616eff20
Author: Alex Heneveld <[email protected]>
Date: 2015-01-29T13:23:18Z
This closes #470
commit 40632adc632c63636f6512fb6d614cb751eb01a0
Author: Alex Heneveld <[email protected]>
Date: 2015-01-29T13:16:46Z
changes to the camp builder to support pure-javac 1.7 compilation
the root cause was (from
http://docs.oracle.com/javase/tutorial/java/javaOO/nested.html):
> Non-static nested classes (inner classes) have access to other members of
the enclosing class, even if they are declared private. Static nested classes
do not have access to other members of the enclosing class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
