Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/479#issuecomment-72204134
looks good. i will add comments to the effect that the
`SERVER_CONF_TEMPLATE_URL` key is only used if `SERVER_CONF_GENERATOR` is
explicitly specified to point to `NginxTemplateConfigGenerator`.
it would probably be cleaner if the DefaultConfigGenerator looked at
`SERVER_CONF_TEMPLATE_URL` key and switched to use it if there is an explicit
value set, just in case someone tries to use the key only. but not needed for
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
