Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/506#discussion_r24325437
  
    --- Diff: 
core/src/main/java/brooklyn/entity/rebind/RebindContextLookupContext.java ---
    @@ -60,6 +66,9 @@ public RebindContextLookupContext(ManagementContext 
managementContext, RebindCon
         @Override public Entity lookupEntity(String id) {
             Entity result = rebindContext.getEntity(id);
             if (result == null) {
    +            result = managementContext.lookup(id, Entity.class);
    --- End diff --
    
    yes - i didn't want to break compatibility, but now i see that i did, and 
that the only usages are during rebind.  have removed that field and added 
javadoc that this class looks in both (which helps justify its existence 
besides the rebind context).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to