Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/506#issuecomment-73509740
@ahgittin I've finished reviewing. Lots of great stuff here.
Two general comments: 1) worth e-mailing brooklyn-dev list about this, as
it is a significant new feature to be able to do in-life upgrades without
restarting the server; 2) worth some more javadoc at the class-level to help
future maintainers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
