Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/525#issuecomment-76914411
@aledsage I'm happy with the hostname changes - this has been an issue for
a few entities in the past so it's great to have this fix available in core
Brooklyn now. I think it could maybe be reworked in the future - I think maybe
my thinking is a bit "old fashioned" and it does seem that OSX does things
slightly differently - but what is here will definitely be reliable and fix
known problems.
I've also reviewed the cluster changes and they seem sane.
:+1: good to merge. Do you want to squash the hostname commits first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
