Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/535#discussion_r26046356
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/AbstractEntity.java ---
    @@ -962,7 +962,9 @@ public void removeAttribute(AttributeSensor<?> 
attribute) {
         // -------- CONFIGURATION --------------
     
         @Override
    -    public ConfigurationSupportInternal config() {
    +    // the concrete type rather than an interface is returned because 
Groovy subclasses
    +    // complain (incorrectly) if we return ConfigurationSupportInternal 
    +    public BasicConfigurationSupport config() {
    --- End diff --
    
    Isn't it better to fix it in a new subclass, meant just for groovy usage? 
Or the subclasses are not directly on this class...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to