Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/552#issuecomment-81689423
looks good. i've some concerns whether the new `BashCommands` do the right
thing in all situations (e.g. if you give a list of commands, but then it is
run as a single CLI rather than a script) but that applies to others as well,
it can be cleaned up as needed. (in general i'd like to move away from them in
any case, to pure yaml.)
minor comment about `=` and `-1` in the filename to be installed. confirm
that's correct and/or add comment and then happy to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
