Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/549#discussion_r26497139
  
    --- Diff: 
core/src/test/java/brooklyn/entity/rebind/persister/BrooklynMementoPersisterToMultiFileTest.java
 ---
    @@ -58,7 +59,10 @@ public void tearDown() throws Exception {
             mementoDir = Os.deleteRecursively(mementoDir).asNullOrThrowing();
         }
     
    -    // to have this picked up in the IDE
    -//    @Test public void noop() {}
    -
    +    @Test(groups="Integration")
    +    public void testLoadAndCheckpointRawMemento() throws Exception {
    +        // test here is deliberately no-op; 
    +        // checkpoint routines not supported for this (deprecated) 
persister
    --- End diff --
    
    I prefer to do `throw new org.testng.SkipException("checkpoint routines not 
supported for this (deprecated) persister")`, but no strong feelings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to