Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/589#discussion_r28204838
--- Diff: core/src/main/java/brooklyn/util/config/ConfigBag.java ---
@@ -132,12 +166,12 @@ public String getDescription() {
/** current values for all entries
* @return non-modifiable map of strings to object */
- public Map<String,Object> getAllConfig() {
- return Collections.unmodifiableMap(config);
+ public synchronized Map<String,Object> getAllConfig() {
--- End diff --
Ah, I see that `getAllConfigMutable` means that we may need to synchronize
on this. I really don't like our uses of `getAllConfigMutable`. Having public
methods like that is an anti-pattern in my opinion.
Longer term, we should deprecate that and also `getUnusedConfigMutable`. We
could have a `getMutex()` method for what to synchronize on, with that marked
`@Beta`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
