Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/592#issuecomment-92204778
on IRC we discussed:
> maybe we should expand getRequiredOpenPorts() to look for any config
which has a segment port and an integer value, e.g. artifactory.http.port ?
alternatively an explicit required.ports config key but that seems clunky.
looks like you've implemented the latter. could we instead do the former,
e.g. in `getRequiredOpenPorts()` also loop through the `getConfig()` and
`getSensors()` finding any where the key's name matches regex `.*\.port` and
checking if their *raw* value is an integer or a string matching `[0-9]+` and
if so then add it? this is a bit of convention magic but it's such a common
convention, and avoids needing to duplicate the ports to open if they are
defined in config keys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
