Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/642#discussion_r30494790
  
    --- Diff: 
sandbox/nosql/src/main/resources/brooklyn/entity/nosql/hazelcast/hazelcast-brooklyn.xml
 ---
    @@ -0,0 +1,58 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +
    +<hazelcast xsi:schemaLocation="http://www.hazelcast.com/schema/config 
hazelcast-config-3.4.xsd"
    +           xmlns="http://www.hazelcast.com/schema/config";
    +           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
    +    <group>
    +        <name>dev</name>
    +        <password>dev-pass</password>
    +    </group>
    +    <management-center 
enabled="false">http://localhost:8080/mancenter</management-center>
    +    <network>
    +        <port auto-increment="true" port-count="100">5701</port>
    +        <outbound-ports>
    +            <!--
    +            Allowed port range when connecting to other nodes.
    +            0 or * means use system provided port.
    +            -->
    +            <ports>0</ports>
    +        </outbound-ports>
    +        <join>
    +            <multicast enabled="false" />
    +
    +            <tcp-ip enabled="true">
    +                <interface>127.0.0.1</interface>
    --- End diff --
    
    This looks like a strange ip to use for join? Will it only work for 
clusters if multiple nodes are running on same machine?
    
    Probably best to inject this using freemarker.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to