Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30501517
--- Diff:
core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
@@ -750,7 +780,36 @@ private String setFromItemIfUnset(String oldValue,
Map<?,?> item, String fieldAt
return oldValue;
}
-
+ /** scans the given libraries for annotated items, or if null scans
the local classpath */
--- End diff --
I'd prefer it if `null` does not mean "local scan". In (too) many other
places we treat null the same as an empty list. Treating it as meaning "local"
will be surprising.
If non-null, does it scan the local classpath as well? I'm finding it hard
to tell from the code what triggers it to scan the local classpath.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
