Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30514538
--- Diff:
core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
@@ -986,7 +1045,12 @@ private DeploymentPlan makePlanFromYaml(String yaml) {
}
private CatalogItem<?,?> addItemDto(CatalogItemDtoAbstract<?, ?>
itemDto, boolean forceUpdate) {
- checkItemNotExists(itemDto, forceUpdate);
+ CatalogItem<?, ?> existingDto =
checkItemIsDuplicateOrDisallowed(itemDto, true, forceUpdate);
+ if (existingDto!=null) {
+ // it's a duplicate, and not forced, just return it
+ log.trace("Using existing duplicate for catalog item {}",
itemDto.getId());
--- End diff --
it could get called a lot in hot backup. and we verified that what we
would do would be no-op before we did nothing so not a useful log message i
think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
