Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30683744
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -665,42 +677,55 @@ protected JcloudsSshMachineLocation
obtainOnce(ConfigBag setup) throws NoMachine
setup.putIfNotNull(JcloudsLocationConfig.PRIVATE_KEY_DATA,
userCredentials.getOptionalPrivateKey().orNull());
// Wait for the VM to be reachable over SSH
- if (waitForSshable) {
+ if (waitForSshable && !windows) {
waitForReachable(computeService, node,
sshHostAndPortOverride, userCredentials, setup);
} else {
LOG.debug("Skipping ssh check for {} ({}) due to config
waitForSshable=false", node, setup.getDescription());
}
usableTimestamp = Duration.of(provisioningStopwatch);
+ JcloudsSshMachineLocation jcloudsSshMachineLocation = null;
--- End diff --
I wonder about just having the `machineLocation` variable, and casting it
where required. Rather than having 3 variables where 1 will be null. Not sure
what the best pattern is for that. The casting would force us to think about it
more, to decide if we can generalise the method to take a machineLocation
instead (and thus work with ssh and windows).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
