Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#issuecomment-103970114
Thanks @nakomis !
I've finished reading through the code. A lot of comments, mostly minor.
Quite a few things can be deferred to future PRs I think.
Could do with some more tests wherever possible as well (again another PR
could potentially do that, as long as we're confident that PR will follow soon
after!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
