Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/633#issuecomment-105841381
@mikezaccardo Thanks again. A few more points:
* We should include empty `Tomcat7Driver` and `Tomcat7SshDriver` classes
that are annotated `@Deprecated` and extend the new sans-7 classes to give
leeway to anyone who has subclassed the old versions.
* I've run classes matching `Tomcat8*IntegrationTest`. All passed but for
`Tomcat8ServerSimpleIntegrationTest.detectFailureIfTomcatCantBindToPort`, which
failed twice after throwing `java.lang.IllegalStateException: Timeout waiting
for SERVICE_UP from Tomcat8ServerImpl{id=HH3Gpo2G}`
* Lastly, it's worth squashing your commits into one before we merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
