Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/671#discussion_r31581022
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1502,8 +1504,7 @@ protected UserCreation createUserStatements(@Nullable
Image image, ConfigBag con
* if this config key is not set, use a key
`brooklyn_id_rsa` and `.pub` in `MGMT_BASE_DIR`,
* with permission 0600, creating it if necessary, and
logging the fact that this was created.
*/
- if (!loggedSshKeysHint &&
!config.containsKey(PRIVATE_KEY_FILE)) {
- loggedSshKeysHint = true;
+ if (loggedSshKeysHint.compareAndSet(false, true) &&
!config.containsKey(PRIVATE_KEY_FILE)) {
--- End diff --
`&&` args should be the other way round so that boolean is only set true if
message is logged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
