Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/697#discussion_r32811012
  
    --- Diff: 
software/webapp/src/test/java/brooklyn/entity/dns/geoscaling/GeoscalingWebClientTest.java
 ---
    @@ -42,8 +42,8 @@
         
         private final static String USERNAME = "cloudsoft";
         private final static String PASSWORD = "cl0uds0ft";
    -    private final static String PRIMARY_DOMAIN = 
"domain"+((int)(Math.random()*10000))+".test.org";
    -    private final static String SUBDOMAIN = 
"subdomain"+((int)(Math.random()*10000));
    +    private final static String PRIMARY_DOMAIN = 
"domain"+((int)(Math.random()*10000) + 10000)+".test.org";
    +    private final static String SUBDOMAIN = 
"subdomain"+((int)(Math.random()*10000) + 10000);
    --- End diff --
    
    Actually, that makes me think we should review the domain cleanup logic in 
the test; looks like tear-down code wasn't executed following previous test 
failures...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to