[ 
https://issues.apache.org/jira/browse/BROOKLYN-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595542#comment-14595542
 ] 

ASF GitHub Bot commented on BROOKLYN-137:
-----------------------------------------

Github user andreaturli commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/707#issuecomment-114045925
  
    @ygy thanks for that! great start!
    
    Do you think it is possible to refactor a bit your implementation? It would 
be nice to rename `IptablesCommands` a more generic `FirewallCommands` 
interface, which is able to use the correct implementation (`iptables` vs 
`firewalld` and possibly `windows firewall`) based on the OsFamily to make it 
more portable?
    
    If so, we should probably deprecate `IptablesCommands` instead of removing 
it immediately.


> Stop Iptables and open iptables don't work on centOS 7
> ------------------------------------------------------
>
>                 Key: BROOKLYN-137
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-137
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: Andrea Turli
>            Assignee: Andrea Turli
>
> RHEL7 introduces firewalld as a replacement to iptables
> http://www.certdepot.net/rhel7-get-started-firewalld/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to