Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/706#discussion_r32917273
--- Diff:
software/base/src/test/java/brooklyn/entity/brooklynnode/BrooklynNodeIntegrationTest.java
---
@@ -361,6 +362,18 @@ protected static void waitForApps(String
webConsoleUri) {
HttpTestUtils.assertHttpStatusCodeEventuallyEquals(webConsoleUri+"/v1/applications",
200);
}
+ protected void waitForApps(final URI webConsoleUri, final int num) {
+ waitForApps(webConsoleUri.toString());
+
+ // e.g. [{"id":"UnBqPcqg","spec":{"name":"Application
(UnBqPcqg)","type":"brooklyn.entity.basic.BasicApplication","locations":["pOL4NtiW"]},"status":"RUNNING","links":{"self":"/v1/applications/UnBqPcqg","entities":"/v1/applications/UnBqPcqg/entities"}}]
+ Asserts.succeedsEventually(new Runnable() {
--- End diff --
I think the test correctly fails in this case. Once the API returns non-403
response all apps are supposed to be rebinded successfully. Clients shouldn't
see inconsistent state.
We should fix the underlying code rather than mask the problem in the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
