Github user mikezaccardo commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/704#discussion_r33054382
--- Diff:
usage/rest-server/src/main/java/brooklyn/rest/resources/LocationResource.java
---
@@ -152,6 +171,15 @@ public Response create(LocationSpec locationSpec) {
@Override
@Deprecated
public void delete(String locationId) {
- brooklyn().getCatalog().deleteCatalogItem(locationId);
+ // TODO make all locations be part of the catalog, then flip the
JS GUI to use catalog api
+ if (deleteAllVersions(locationId)>0) return;
--- End diff --
Personal preference: make the condition == 0 then throw, no return
necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
