Github user mikezaccardo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/714#discussion_r33172710
  
    --- Diff: core/src/main/java/brooklyn/util/flags/MethodCoercions.java ---
    @@ -0,0 +1,183 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.util.flags;
    +
    +import brooklyn.util.exceptions.Exceptions;
    +import brooklyn.util.guava.Maybe;
    +import com.google.common.base.Optional;
    +import com.google.common.base.Predicate;
    +import com.google.common.collect.Iterables;
    +import com.google.common.reflect.TypeToken;
    +
    +import javax.annotation.Nullable;
    +import java.lang.reflect.InvocationTargetException;
    +import java.lang.reflect.Method;
    +import java.lang.reflect.Type;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +import static com.google.common.base.Preconditions.checkNotNull;
    +
    +/**
    + * A way of binding a loosely-specified method call into a strongly-typed 
Java method call.
    + */
    +public class MethodCoercions {
    +
    +    /**
    +     * Returns a predicate that matches a method with the given name, and 
a single parameter that
    +     * {@link brooklyn.util.flags.TypeCoercions#tryCoerce(Object, 
com.google.common.reflect.TypeToken)} can process
    +     * from the given argument.
    +     *
    +     * @param methodName name of the method
    +     * @param argument argument that is intended to be given
    +     * @return a predicate that will match a compatible method
    +     */
    +    public static Predicate<Method> matchSingleParameterMethod(final 
String methodName, final Object argument) {
    --- End diff --
    
    Could be good to add `@Nonnull` to the params.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to