GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/731
Count the null values for the average enrichers
This fixes TomcatAutoScalerPolicyTest
Basically the problem is that after making a request to Tomcat uptade event
for REQUEST_COUNT_PER_NODE is triggered immediately.
This causes Enrichers.average() to have a null value for the requests of
the newly created Tomcat Entity.
This leads to average of 2 requests per node which exceeds the allowed
metric of 0 to 1 which triggers scaling.
It is discuss-able whether we should apply the fix here, but I think in the
general case it is good to include null for average values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/731.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #731
----
commit 45f1ec1c134b17ab3860db65998ead88426769b6
Author: Valentin Aitken <[email protected]>
Date: 2015-07-01T14:31:02Z
Count the null values for the average enrichers
This fixes TomcatAutoScalerPolicyTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
