GitHub user rdowner opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/746
Fix dist to have suitable name, and suitably-named directory inside
In commit 56285ad89cc2ba7b9ea540cfb0de25f411d14e29, which modifies the way
that Brooklyn dist is built, @ahgittin notes: *"finalName affects name in
`target/` but we cannot influence name when it is attached/installed, so
`apache-` prefix would be lost there. to keep it consistent this is commented
out, but would be nice to have if there is a way!"*
However I am not certain why this is an issue, and why we need to insist
that the built artifact name must be consistent with the attached-artifact
name. The primary concern of the distribution is a single downloadable binary
archive. This archive should be named appropriately for the product, and
convention dictates that the archive contains a single directory with the same
name as the archive, and that directory contains all the files.
maven-assembly-plugin will also upload them to the repository, but forces them
to be a particular name. However, *that isn't important* - users aren't going
to get the binary download by digging through Maven repositories, they are
going to get it from the Apache download page. The Maven artifact of the
distribution is merely a side effect, so does it really matter what its name is?
This PR changes the name of the archives to
`apache-brooklyn-VERSION-bin.tar.gz` and `.zip`. Each contains a single folder,
`apache-brooklyn-VERSION-bin`, which contains all the files for the
distribution.
This corresponds to the release process, which is producing names and
formats identical except that `bin` is substituted for `src`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdowner/incubator-brooklyn
dist-artifact-naming
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #746
----
commit 61a01dad2b7bebc79df93f7e58e434a570ef9ec5
Author: Richard Downer <[email protected]>
Date: 2015-07-14T17:21:30Z
Fix dist to have suitable name, and suitably-named directory inside
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
